Fix a pagination bug (where clauses aren't taking into account) #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanharmelen
force-pushed
the
fix/pagination-info
branch
5 times, most recently
from
fda1d2a to
bc08fd9
Compare
svanharmelen
force-pushed
the
fix/pagination-info
branch
from
bc08fd9 to
4863c95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that the actual fix in is the second commit, the first commit only contains some small improvements trying to make the Go code in
postgres.goa little idiomatic. Yet if there are any comments on that I perfectly fine to drop that commit and only push the commit with the actual fix 👍🏻